Vault private ingress - #437
Open
BogdanAntoniu78 wants to merge 6 commits into
Open
Conversation
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
BogdanAntoniu78
requested review from
davidspek and
michaeljguarino
as code owners
November 13, 2022 08:38
| nginx.ingress.kubernetes.io/force-ssl-redirect: "true" | ||
| nginx.ingress.kubernetes.io/use-regex: "true" | ||
| {{- if not .Values.exposePrivate }} | ||
| ingressClassName: nginx |
Member
There was a problem hiding this comment.
A lot of these values should actually be moved down to values.yaml since the current setup prevents reconfiguration. Really we should have nginx as the default there then overwrite with:
{{ if .Values.exposePrivate }}
ingressClassName: internal-nginx
{{ end }}
in values.yaml.tpl
Contributor
Author
There was a problem hiding this comment.
Sure. I moved the values to values.yaml.tpl. Ihad to leave also the else statement, as otherwise the className gets undefined.
- moved from tpl to value.yaml ingress values - bumped the chart version
Changed the logic on exposePrivate boolean value
michaeljguarino
approved these changes
Dec 16, 2022
Member
|
It looks like this does have a merge conflict to resolve |
Contributor
Author
|
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes on this PR:
Test Plan
Checklist
plural from-grafanato convert a grafana dashboard found via google to our CRDpluralsh/module-libraryto accelerate this