fix(lightdash/aws): migrate deprecated kubernetes namespace and service account resources to v1 - #932
Open
bpc-oss wants to merge 1 commit into
Open
fix(lightdash/aws): migrate deprecated kubernetes namespace and service account resources to v1#932bpc-oss wants to merge 1 commit into
bpc-oss wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #930.
This switches the Lightdash AWS Terraform module from the deprecated Kubernetes resources to the v1 resources and updates the
depends_onreference to match.I validated the module in an isolated copy with:
terraform fmt -check main.tfterraform init -backend=falseterraform validateI also checked the upgrade path against existing state in a local kind/Terraform lab. A straight rename is not enough here: Terraform plans to destroy and recreate these resources, and
movedis not supported for this type change. The safe path I found was a one-time root-level migration usingremoved { destroy = false }andimport. After importing state into the_v1addresses, the nextterraform planis clean.The checked-in
terraform.tfvarsis only a template, so the validation run used temporary concrete values fornamespaceandcluster_name.I did not run a full
plural link/build/deployflow from this environment.Existing-state migration note
Because Terraform does not support
movedacross these resource types, existing installs need a one-time root-level migration during upgrade. The pattern I tested was:After that apply, the next
terraform planshould be clean.