Roll back to pre-macro state with Swift 6 modernizations #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or stringification.
- Preserved Swift 6 language mode and platform requirements - Added Sendable conformances to Quaternion type - Fixed static property concurrency warnings with nonisolated(unsafe) - Updated deprecated Package.swift API (swiftLanguageModes) - Created planning/ directory with: - macro-migration-roadmap.md: Comprehensive 6-phase migration plan - macro-migration-prompts.md: Specific prompts for each phase - Project now compiles successfully with Swift 6 - No build artifacts included in this commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR rolls back the incomplete macro migration attempt while preserving valuable Swift 6 modernizations. It provides a clean foundation for future incremental macro migration.
Changes
Swift 6 Modernizations Preserved
nonisolated(unsafe)for static propertiesMacro Work Removed
Documentation Added
planning/macro-migration-roadmap.md: Comprehensive 6-phase migration planplanning/macro-migration-prompts.md: Specific prompts for each migration phaseContext
The original macro migration (on
feat/swift-modernizationbranch) attempted to:However, the migration got stuck due to its ambitious scope. This PR provides a clean slate for a more incremental approach.
Test Plan
Next Steps
Follow the roadmap in
planning/macro-migration-roadmap.mdfor incremental macro migration.🤖 Generated with Claude Code