-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: ChangeLog supplement for #6117 and #6127 #6136
Conversation
Signed-off-by: Tomasz Gromadzki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72 and @osalyk)
ChangeLog
line 1 at r1 (raw file):
DoW Mmm DD YYYY Somebody <[email protected]>
ChangeLog
line 1 at r1 (raw file):
DoW Mmm DD YYYY Somebody <[email protected]>
I am not so sure having so elaborate placeholder is better. I guess before the release, the best matching line of this kind is just copied over and adjusted. Having to replace a few words instead of just one may be more error prone and IMHO simplifies nothing. Thoughts? @osalyk?
ChangeLog
line 7 at r1 (raw file):
- remove non-Linux support from all compilation paths (OS_KERNEL_NAME) - add an aarch64 cross-compilation (requested by DAOS) - mute annoying error messages when transactions are intentional abort (#6117)
Or intentional aborts
? What does it mean "things are abort"? If you can argue for this case please do because I am sincerely curious.
Suggestion:
mute annoying error messages when transactions are intentionally aborted
ChangeLog
line 8 at r1 (raw file):
- add an aarch64 cross-compilation (requested by DAOS) - mute annoying error messages when transactions are intentional abort (#6117) - mute error message "Cannot find any matching device, no bad blocks found" when PMDK is used without PMem (#6127)
There are some spaces before tab. Please remove.
ChangeLog
line 8 at r1 (raw file):
- add an aarch64 cross-compilation (requested by DAOS) - mute annoying error messages when transactions are intentional abort (#6117) - mute error message "Cannot find any matching device, no bad blocks found" when PMDK is used without PMem (#6127)
It is good to know this one was not so annoying as the previous one. 😆
Code quote:
error message
Signed-off-by: Tomasz Gromadzki <[email protected]>
517fdd9
to
f279d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)
ChangeLog
line 1 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
I am not so sure having so elaborate placeholder is better. I guess before the release, the best matching line of this kind is just copied over and adjusted. Having to replace a few words instead of just one may be more error prone and IMHO simplifies nothing. Thoughts? @osalyk?
Done
ChangeLog
line 7 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Or
intentional aborts
? What does it mean "things are abort"? If you can argue for this case please do because I am sincerely curious.
Done.
ChangeLog
line 8 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
There are some spaces before tab. Please remove.
Done.
ChangeLog
line 8 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
It is good to know this one was not so annoying as the previous one. 😆
Done.
ChangeLog
line 1 at r1 (raw file):
DoW Mmm DD YYYY Somebody <[email protected]>
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @grom72)
This change is