-
Notifications
You must be signed in to change notification settings - Fork 94
Tutorial fluid modelling #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial fluid modelling #1385
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Some high-level comments after the first readthrough:
|
Thanks for the feedback @mariusnevland. I'll have a look and keep your comments in mind. |
Most important: This will become extremely useful for everyone as we introduce more advanced fluid modeling. I only managed to read half the tutorial before I had to run, will try to cover the second half no later than Monday. I tried to keep the comments on a high level, it seems to me we should focus on getting the context and general disposition of the tutorial right before getting into details. |
I left a few more comments. @vlipovac I suggest we discuss how to approach this PR at some point. |
|
Closes #1254
Proposed changes
Adding a tutorial for modeling of multiphase and multicomponent fluids.
Changing the configuration of phases to omit the default
EquationOfState
and hence simplifying the setup for models not relying on EoS computations.Types of changes
Checklist
pytest
was run with the--run-skipped
flag.