Skip to content

Delete code previously marked for deprecation #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

keileg
Copy link
Contributor

@keileg keileg commented Apr 23, 2025

Proposed changes

Deleted the following that has long been marked for deprecation:

  1. Utility functions in FractureNetwork3d
  2. The module coarsening together with tests
  3. Functionality for MVEM/MFEM to compose mixed-dimensional discretizations using the old assembler-style techniques.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other: Deprecations

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

keileg added 3 commits April 23, 2025 06:32
The functions were closely tied to the long-gone Assembler-approach for
composing mixed-dimensional discretizations
@keileg keileg linked an issue Apr 23, 2025 that may be closed by this pull request
@keileg
Copy link
Contributor Author

keileg commented Apr 23, 2025

@jwboth I realized that we actually use the coarsening module (which has long been deprecated) for testing of the exporter applied to polytopal grids. Is this something we need, and are there ways in which we can circumvent this (I can implement if you can give me some guidance)?

Of course we can un-deprecate the module, but there is a certain cost in maintenance to that code, so I don't want to do this if there are other ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete code marked for deprecation
1 participant