Skip to content

Conversation

@IvarStefansson
Copy link
Contributor

Proposed changes

Adds an example for a relatively simple subsurface simulation case. In addition to the run script, notable additions are the geometry (two wells and two elliptic fractures) and BCs and ICs based on thermal gradient/hydrostatic pressure/lithostatic stress.

No testing as of yet.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

Copy link
Contributor

@keileg keileg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, I have covered everything except from geothermal_reservoir.py, but ran out of time and energy. Hopefully I can complete the review tomorrow.

From what I have seen so far, this will be very useful. There are some topics I think we should discuss in person (see detailed comments), but I have no significant concerns at this stage.

Copy link
Contributor

@keileg keileg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the run script. Nice work!

Copy link
Contributor

@keileg keileg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when comments are resolved and let me know if you want further input from my side.

@IvarStefansson IvarStefansson force-pushed the geothermal-reservoir-example branch from 9efed9f to 5c98de0 Compare December 8, 2025 14:15
@IvarStefansson IvarStefansson marked this pull request as ready for review December 8, 2025 14:15
@IvarStefansson IvarStefansson merged commit b84bb3a into develop Dec 8, 2025
5 checks passed
@IvarStefansson IvarStefansson deleted the geothermal-reservoir-example branch January 6, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants