-
Notifications
You must be signed in to change notification settings - Fork 99
Geothermal-reservoir-example #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
keileg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review, I have covered everything except from geothermal_reservoir.py, but ran out of time and energy. Hopefully I can complete the review tomorrow.
From what I have seen so far, this will be very useful. There are some topics I think we should discuss in person (see detailed comments), but I have no significant concerns at this stage.
src/porepy/applications/boundary_conditions/model_boundary_conditions.py
Outdated
Show resolved
Hide resolved
src/porepy/applications/boundary_conditions/model_boundary_conditions.py
Show resolved
Hide resolved
src/porepy/applications/boundary_conditions/model_boundary_conditions.py
Show resolved
Hide resolved
keileg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of the run script. Nice work!
keileg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge when comments are resolved and let me know if you want further input from my side.
9efed9f to
5c98de0
Compare
Proposed changes
Adds an example for a relatively simple subsurface simulation case. In addition to the run script, notable additions are the geometry (two wells and two elliptic fractures) and BCs and ICs based on thermal gradient/hydrostatic pressure/lithostatic stress.
No testing as of yet.
Types of changes
What types of changes does this PR introduce to PorePy?
Put an
xin the boxes that apply.Checklist
Put an
xin the boxes that apply or explain briefly why the box is not relevant.pytestwas run with the--run-skippedflag.