Skip to content

Conversation

@IvarStefansson
Copy link
Contributor

Proposed changes

Creates three new model exporting classes:

  • Equation residuals
  • Iterations (promoted from tutorial
  • Fracture quantities (some new fields, some refactored from base DataSaving). This makes the PR BREAKING, since apertures and specific volumes are no longer exported by default.

Main questions:
Do the current models seem like valuable additions striking reasonable balance between convenience and cost (size of exported files)?
How do we want to test these classes?

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@jwboth jwboth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall very good to me. I only have comments with potential improvements.

@keileg keileg merged commit f2c046f into develop Dec 22, 2025
6 checks passed
@IvarStefansson IvarStefansson deleted the model-exporting-refactor branch January 6, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants