Skip to content

Conversation

@jwboth
Copy link
Contributor

@jwboth jwboth commented Jan 6, 2026

Proposed changes

I noticed some minor issues when using the new functionality for exporting iterations and fracture quantities:

  • The folder definition for the exported iterations does not work for Path objects.
  • The numbering of exported data was wrong.
  • Iteration exporting did not take care of non-unitary length scale units.
  • The exporting of tractions was hardcoded for 3d.

This PR aims at fixing these issues.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

Tests have been ignored (as before for these convenience classes).

Copy link
Contributor

@IvarStefansson IvarStefansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jwboth jwboth merged commit e2ed09d into develop Jan 7, 2026
6 checks passed
@jwboth jwboth deleted the minor-fix-exporting branch January 7, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants