Ender eye placement in portal frame #5913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShockedPlot7560
added
Category: Gameplay
dktapps
reviewed
Jul 19, 2023
dktapps
reviewed
Jul 31, 2023
dktapps
reviewed
Aug 7, 2023
Joshy3282
added a commit
to Joshy3282/PocketMine-MP
that referenced
this pull request
Oct 2, 2024
Member
|
I stalled on this because I don't like the Eye of Ender being added as a generic item. From reading the code there's no obvious indication that there's more work to be done (e.g. adding projectile functionality). Unsure if this might cause BC blockers for PM5 if additional functionality were to be implemented. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
This PR has been marked as "Waiting on Author", but we haven't seen any activity in 7 days. If there is no further activity, it will be closed in 28 days. Note for maintainers: Adding an assignee to the PR will prevent it from being marked as stale. |
![pmmp-admin-bot[bot]](https://avatars.githubusercontent.com/in/1059952?s=60&v=4){kind=small}
Member
Author
|
I will not work anymore on this PR, feel free to take over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This is an update/improvement of : #4850
Changes
Behavioural changes
Tests
2023-07-18-18-33-33.mp4