Optimized combining of listeners #6112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF3
reviewed
Oct 23, 2023
| @@ -130,26 +129,24 @@ public function getListenerList() : array{ | |||
| } | |||
|
|
|||
| $listenersByPriority = []; | |||
| $concurrentAsyncListenersByPriority = []; | |||
There was a problem hiding this comment.
Are you sure we want 34-character-long variable names?
There was a problem hiding this comment.
The other option is to make $listenersByPriorityByType[0], $listenersByPriorityByType[1], and $listenersByPriorityByType[0] but if we don't hardcode these values it would make it longer than before.
There was a problem hiding this comment.
Do we actually need to mention all four keywords ("concurrent", "async", "priority", "listener") in the same variable name?
There was a problem hiding this comment.
I don't think so, we have to find shorter terms.
|
Superseded by aaa37ba |
ShockedPlot7560
added
Category: Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Helping the #6092 PR.