Fix/2514 update types three webglprogram #2515
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Multiple files in the codebase contain outdated FIXME comments referencing
@types/[email protected]
and use custom type definitions instead of the officialTHREE.WebGLProgramParametersWithUniforms
type that is now available in the current version of@types/three
.Resolves #2514
What
THREE.WebGLProgramParametersWithUniforms
in 4 files@types/[email protected]
shader.defines
in MeshTransmissionMaterialFiles updated:
src/core/MeshWobbleMaterial.tsx
- UpdatedonBeforeCompile
parameter typesrc/core/MeshDistortMaterial.tsx
- UpdatedonBeforeCompile
parameter typesrc/core/useBoxProjectedEnv.tsx
- ReplacedMaterialShader
interface with official typesrc/core/MeshTransmissionMaterial.tsx
- Updated type and added null checks forshader.defines
Benefits:
WebGLProgramParameters
(likefragmentShader
,defines
, etc.)Checklist