feat(ScrollControls&Html): add pixelPerfect prop to prevent subpixel blur
#2541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artokun is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Adds pixelPerfect prop to prevent subpixel rendering blur caused by CSS transform3d values with decimal pixels. Uses devicePixelRatio-based rounding for accurate rendering across all display types. Features: - ScrollControls: pixelPerfect prop for Scroll html components - Html: pixelPerfect prop for transform mode - Velocity-based optimization (only applies when motion < 0.001) - devicePixelRatio support for high-DPI displays - Comprehensive Storybook examples and documentation - Performance optimized with conditional application Credit: chris-xinhai-li for devicePixelRatio suggestion (pmndrs#2380) Fixes: pmndrs#859, pmndrs#2380 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
artokun
force-pushed
the
feat/scroll-pixel-perfect
branch
from
a7135bc to
9f0fc53
Compare
artokun
changed the title
ScrollControls): add pixelPerfect prop to ScrollControls to prevent subpixel blur
artokun
changed the title
ScrollControls): add pixelPerfect prop to ScrollControls to prevent subpixel blurScrollControls&Html): add pixelPerfect prop to ScrollControls to prevent subpixel blur
artokun
changed the title
ScrollControls&Html): add pixelPerfect prop to ScrollControls to prevent subpixel blurScrollControls&Html): add pixelPerfect prop to prevent subpixel blur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pixelPerfectprop to bothScrollControlsandHtmlcomponents to prevent subpixel rendering blur caused by CSStransform3dvalues with decimal pixels.Problem
HTML elements rendered with CSS transforms in 3D scenes often appear blurry due to subpixel positioning, especially during animations. This affects text readability and overall visual quality, as discussed in issues #859 and #2380.
Solution
Implements a
pixelPerfectprop that rounds transform values to whole pixels usingdevicePixelRatio-based calculation for accurate rendering across all display types.Key Features
pixelPerfectprop for<Scroll html>componentspixelPerfectprop for transform mode renderingwindow.devicePixelRatioUsage
Implementation Details
roundToPixelRatio()useswindow.devicePixelRatiofor accurate roundingDocumentation & Examples
Credit
Special thanks to @chris-xinhai-li for suggesting the
devicePixelRatioapproach in issue #2380.Fixes
Testing
The feature has been thoroughly tested with: