fix(ScrollControls): cache ReactDOM root for React 19 compatibility #2557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent duplicate
createRoot()
calls by caching the root instance on the DOM element, fixing React 19 error on component remount.Why
React 19 throws an error when
ReactDOM.createRoot()
is called multiple times on the same container.ScrollHtml
was creating a new root on each remount, breaking compatibility with React 19.What
__r3_root
propertyChecklist