fix: make Html occlusion material transparent#2736
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
|
@raashish1601 is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #2352.
Html's default blending occlusion plane uses a shader that writesvec4(0.0, 0.0, 0.0, 0.0), but the generatedshaderMaterialwas not marked as transparent. That means the alpha channel can be ignored by the material pipeline, leaving an opaque backing square behind simple HTML content.What
Mark the default occlusion
shaderMaterialastransparentso its zero-alpha fragment is actually blended away. Custommaterialprops are left untouched.Checks
corepack yarn prettier --check src/web/Html.tsxcorepack yarn eslint src/web/Html.tsxcorepack yarn typecheckcorepack yarn build(passes with existing Rollup unused-import warnings and outdated Browserslist data warning)git diff --check