fix: Expo SDK 54 compatibility through workaround #3599
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextoudic
changed the title
CodyJasonBennett
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 52af270:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
TypeError: Cannot read property 'Base64' of undefinederror on Expo SDK 54, caused byexpo-file-system/nextbecoming the default export and the old API moving toexpo-file-system/legacy(see #3583).This update adds a conditional import that uses
expo-file-system/legacywhen available (Expo SDK 54) and falls back to the default import otherwise. This keeps the polyfill working across both older and newer Expo releases.Note:
It uses a try / catch approach as requiring
expo-file-system/legacyon former versions of Expo will raise aUnable to resolve "expo-file-system/legacy" from "node_modules/@react-three/fiber/native/dist/react-three-fiber-native.cjs.prod.js"error