V10-fix-canvas-override #3629
Merged
V10-fix-canvas-override #3629
+212
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New lastConfiguredProps object becomes test source. closes canvas resize causes frameloop to reset to default setting Fixes pmndrs#3531 Fixes Re-renders cause DPR to be reset to the initial value Fixes pmndrs#3535 Adds tests against those two test cases
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 13702e2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New lastConfiguredProps object becomes test source.
closes canvas resize causes frameloop to reset to default setting
Fixes #3531
Fixes Re-renders cause DPR to be reset to the initial value
Fixes #3535
Adds tests against those two test cases