Fix broken tests, a bug fix for text boxes with numbers in them, and CI setup.
#215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR currently the typings do not support numbers, but as I just learned writing 123 in react provides the children as a number so it might be a good idea to adapt the types also Regarding the tests you are adding "waitForEffects" which I am not getting since I am using the synchronous veryion of preact/signals. Is there a reason you are doing this? |
|
@bbohlender fixed! turns out boolean values could be there too. I didn't understand what was happening with the sync version of preact/signals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tests, adds CI setup that should show you if the test break again, and fixes a bug when a page number box has a
numberin it.