fix: preserve pointer capture when leaving and re-entering window #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where dragging an object outside the browser window and returning would break drag behavior. ## Changes - Skip exit event when pointer leaves with capture held and button pressed - Re-establish DOM pointer capture on move if logical capture still exists - Wrap releasePointerCapture in try-catch for already-released pointers ## Test Added test cases for window leave/re-enter scenarios.
Contributor
Author
|
I get the error "TypeError: ev.target.closest is not a function" if I left-drag something offscreen, hold down right button, then release left. However this seems to be an issue with Ublock Origin on FF and not xr. |
Collaborator
|
@neftaly Hey, thanks for the PR I unfortunately do not understand the underlying issue since we are captuing the pointer, there should not be an exit event from the browser and releasePointerCapture should only work if we have not released yet. Do the tests reproduce the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where dragging an object outside the browser window and returning would break drag behavior.
Changes
Test
Added test cases for window leave/re-enter scenarios.
Notes
Hi Bela!