Skip to content

ci(.github/workflows): rename 'cr' to 'preview-release' #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Mar 29, 2025

Summary

  • relate ci(.github/workflows): add 'test.yml' and rename job #3059
    • In pkg-pr-new, pr stands for preview release. Therefore, I concluded that changing it to preview release feels more natural than using cr.
    • I have determined that preview release is also appropriate for standardizing the file name, title, and job name

Check List

  • pnpm run fix for formatting and linting code and docs

Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 6:01am

Copy link

codesandbox-ci bot commented Mar 29, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Mar 29, 2025

demostarter

npm i https://pkg.pr.new/zustand@3069

commit: 5b19292

@dai-shi
Copy link
Member

dai-shi commented Mar 29, 2025

I think the term cr is coined by them.
Leaving this to @Aslemammad .

@dai-shi dai-shi requested a review from Aslemammad March 29, 2025 12:54
@sukvvon
Copy link
Contributor Author

sukvvon commented Mar 29, 2025

@dai-shi @Aslemammad

https://github.com/vitejs/vite/blob/main/.github/workflows/preview-release.yml

I referred to the above file because it seems similar to what we aim for.

Copy link
Member

@Aslemammad Aslemammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff! Thank you so much.

@Aslemammad
Copy link
Member

cr means continuous releases but I agree that shorting that might not be ideal. I like both continuous-releases and preview-releases!

@dai-shi dai-shi merged commit 473cfbf into pmndrs:main Apr 15, 2025
27 checks passed
@sukvvon sukvvon deleted the ci/rename-cr-to-preview-release branch April 15, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants