docs: add currying for createStore#3171
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
|
I'm fine to add it as it's TS code. |
Collaborator
|
@dai-shi in the new docs under apis/middlewares we talked about that, we do have ts examples. BTW, everything else use js examples. |
dai-shi
reviewed
Jul 9, 2025
| } | ||
|
|
||
| const store = createStore<BearState>((set) => ({ | ||
| const store = createStore<BearState>()((set) => ({ |
Member
There was a problem hiding this comment.
This is a TS example, so it makes sense to have ().
Or, do you have a PR/branch that will be merged later? @dbritto-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this is a correct change, but I was reading the docs, and if I didn't misunderstand, we always need to do currying when creating a store with typescript. This seemed to be missing in the code example used in auto generating selectors.