test: expand React subscribe test coverage#3442
Merged
dbritto-dev merged 2 commits intoMar 30, 2026
Merged
Conversation
The React-level subscribe.test.tsx only had a single test checking that subscribe is a function. This adds comprehensive tests mirroring the vanilla subscribe tests, covering state change notifications, subscribeWithSelector integration, equality functions, unsubscription, fireImmediately, and multiple subscriber behavior.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
|
thanks for your contribution |
dai-shi
reviewed
Mar 30, 2026
| import { describe, expect, it } from 'vitest' | ||
| import { describe, expect, it, vi } from 'vitest' | ||
| import { create } from 'zustand' | ||
| import { subscribeWithSelector } from 'zustand/middleware' |
Member
There was a problem hiding this comment.
btw, we will probably drop this in the next major version.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The React-level
tests/subscribe.test.tsxonly had a single test that checkedtypeof subscribe === 'function'. Meanwhile, the vanilla counterpart (tests/vanilla/subscribe.test.tsx) has 9 comprehensive tests.This expands the React subscribe tests to cover actual subscription behavior through the
create()API.Tests Added
subscribeWithSelector: slice-based subscriptionssubscribeWithSelector: custom equality functionssubscribeWithSelector:fireImmediatelyoptionGoes from 1 test → 12 tests for React subscribe behavior.
Verification