Make the gdbm subproject build on GCC 10 #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two variables were not declared as extern. This works until GCC 9, due to the common model, but his has been disabled on GCC 10, which therefore requires changes. See https://bugs.gentoo.org/705898.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the gdbm subproject build on GCC 10
Two variables were not declared as extern. This works until GCC 9, due to the common model, but his has been disabled on GCC 10, which therefore requires changes. See https://bugs.gentoo.org/705898.
This is a patch of a vendored library (gdbm). Possibly, the formal solution is to upgrade to a more recent version, however, until that's done, compiling on GCC 10 is something that needs to be handled.
A potential solution is to pass
-fcommonas CFLAGS down to the makefiles, but I don't know how to do that and if that's possible.Closes #145.