chore: replace true and false#1241
Merged
bates64 merged 3 commits intopmret:mainfrom Jul 25, 2025
a2937:chore/true-false-enum
Merged
chore: replace true and false#1241bates64 merged 3 commits intopmret:mainfrom a2937:chore/true-false-enum
bates64 merged 3 commits intopmret:mainfrom
a2937:chore/true-false-enum
Conversation
Member
|
The changes here look good to me. This project just has an enormous number of source files. Unfortunately the build is failing for some reason due to "bool" being defined twice. I'm trying to figure out where the other place is.,, |
Contributor
Author
|
My Visual Studio Code installation was acting up while I was making it and complained about the item_enum. I did not intend to have a code error. |
ethteck
reviewed
Jul 24, 2025
Member
|
I fixed several issues that fell out of making this change. I hope you don't mind if I push them to this PR, since they're needed for the build to pass |
ethteck
approved these changes
Jul 24, 2025
Contributor
Author
|
I don't mind at all. The only thing I care about is the code working. |
bates64
requested changes
Jul 24, 2025
bates64
approved these changes
Jul 25, 2025
bates64
added a commit
to bates64/papermario-dx
that referenced
this pull request
Jan 4, 2026
bates64
added a commit
to bates64/papermario-dx
that referenced
this pull request
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like I did something not quite right here in this PR given all the changed files.
Closes #1169