Skip to content

8830 refactoring(styles): Layout errors on the template creation page #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pneumatic-ilyacedrik wants to merge 7 commits into
base: master
Choose a base branch
from
Open

8830 refactoring(styles): Layout errors on the template creation page #198

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4c158a
8830 refactor: Enhance task view styling: Add text overflow handling …
pneumatic-ilyacedrik Apr 8, 2026
065cb5f
8830 refactor(TaskForm): Remove title prop from TaskDescriptionEditor…
pneumatic-ilyacedrik Apr 8, 2026
648605f
8830 style: Update ExtraField styles by adding margin-top to kickoff-…
pneumatic-ilyacedrik Apr 8, 2026
9cf596a
8830 style: Consolidate margin-top styles for label elements in Kicko…
pneumatic-ilyacedrik Apr 8, 2026
de83dda
8830 style: Simplify padding and positioning in ExtraFieldCheckbox an…
pneumatic-ilyacedrik Apr 8, 2026
21cfd02
8830 style: Add text-small mixin to kickoff-create-field-add-option i…
pneumatic-ilyacedrik Apr 8, 2026
3a3ee10
8830 style: Enhance FieldWithName component and KickoffRedux styles f…
pneumatic-ilyacedrik Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/public/components/TemplateEdit/ExtraFields/Checkbox/ExtraFieldCheckbox.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
}

.kickoff-create-field-name-input {
padding: 0 4px 0 0;
max-width: calc(100% - 5px);
padding: 0;
line-height: 20px;
border: none;

Expand Down Expand Up @@ -89,6 +88,8 @@
}

.kickoff-create-field-add-option {
@mixin text-small;

margin: 0;
padding: 0;
overflow: visible;
Expand Down
7 changes: 3 additions & 4 deletions frontend/src/public/components/TemplateEdit/ExtraFields/Creatable/ExtraFieldCreatable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@

.kickoff-create-field-options {
margin: 0;
margin-top: 0.8rem;
padding: 0;
list-style: none;
}
Expand Down Expand Up @@ -133,6 +134,8 @@
}

.kickoff-create-field-add-option {
@mixin text-small;

margin: 0;
padding: 0;
overflow: visible;
Expand Down Expand Up @@ -166,10 +169,6 @@
align-items: center;
}

.kickoff-dropdown-field {
Copy link
Copy Markdown

@cursor cursor Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead CSS class references after style removal

Low Severity

The .kickoff-dropdown-field CSS class was removed from both ExtraFieldCreatable.css and ExtraFieldUser.css, but the corresponding TSX files still reference inputStyles['kickoff-dropdown-field'] — in ExtraFieldCreatable.tsx (line 170) and ExtraFieldUser.tsx (line 65). With CSS Modules, these resolve to undefined, making them dead references that are silently passed as inputClassName to FieldWithName.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 21cfd02. Configure here.

margin-bottom: 8px;
}

.kickoff-create-field__error-text {
margin-top: 4px;
margin-bottom: 0;
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/public/components/TemplateEdit/ExtraFields/Radio/ExtraFieldRadio.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@
}

.kickoff-create-field-add-option {
@mixin text-small;

margin: 0;
padding: 0;
overflow: visible;
Expand Down
4 changes: 0 additions & 4 deletions frontend/src/public/components/TemplateEdit/ExtraFields/User/ExtraFieldUser.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,6 @@
}
}

.kickoff-dropdown-field {
margin-bottom: 8px;
}

.kickoff-create-field__error-text {
margin-top: 4px;
margin-bottom: 0;
Expand Down
12 changes: 1 addition & 11 deletions frontend/src/public/components/TemplateEdit/KickoffRedux/KickoffRedux.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,8 @@
color: var(--pneumatic-color-warning);
}

.without-label,
.with-label {
margin-top: 2.3rem;
}

.without-label {
margin-top: 1.6rem;
}

Expand Down Expand Up @@ -499,8 +496,6 @@
}

.kick-off-required-sign {
position: relative;
left: -0.3rem;
flex-shrink: 0;
display: inline-block;
width: 0.68rem;
Expand All @@ -519,11 +514,6 @@
}
}

.kick-off-required-sign + .kick-off-edit-name {
position: relative;
left: -0.3rem;
}

.workflow-name-field-container {
margin-top: 3.2rem;
}
Expand Down
1 change: 0 additions & 1 deletion frontend/src/public/components/TemplateEdit/TaskForm/TaskDescriptionEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export function TaskDescriptionEditor({
return (
<RichEditor
ref={editorRef}
title={formatMessage({ id: 'tasks.task-description-field' })}
placeholder={formatMessage({ id: 'template.task-description-placeholder' })}
defaultValue={value}
handleChange={handleChange}
Expand Down
1 change: 0 additions & 1 deletion frontend/src/public/components/TemplateEdit/TaskForm/TaskForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ export function TaskForm({
return Promise.resolve(value);
}}
className={styles['task-name-field']}
title={formatMessage({ id: 'tasks.task-task-name' })}
toolipText={formatMessage({ id: 'tasks.task-description-button-tooltip' })}
/>
<TaskDescriptionEditor
Expand Down
4 changes: 4 additions & 0 deletions frontend/src/public/components/TemplateEdit/TemplateEdit.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@
color: var(--pneumatic-color-black72);
}

.task_view-description > * {
@mixin text-overflow 3;
}

.task-preview-performers {
margin: 1.6rem 0;
}
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/public/components/icons/DropdownCrossIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* eslint-disable */
/* prettier-ignore */
/* eslint-disable max-len */
import * as React from 'react';

export type TDropdownCrossIconProps = React.SVGAttributes<SVGElement>;
Expand Down