Skip to content

Conversation

@cristiano-masutti
Copy link

went back to working libpng commit

@jbowler
Copy link
Contributor

jbowler commented May 25, 2025

@bobfriesenhahn simply delete the contrib/oss-fuzz directory. I have never not once managed to get it to do anything useful. Apparently Glenn could but he never explained the particular magic environment required and there is no support in cmake or configure or even a script.

If there is one single thing on this planet that managed to convince me that fuzzing is a complete waste of time this directory is it.

@bobfriesenhahn
Copy link
Contributor

@jbowler, Due to maintaining GraphicsMagick's oss-fuzz build, I have some knowledge of how things work. Part of the build is controlled by oss-fuzz project scripts, but libpng's own contrib/oss-fuzz/build.sh is executed due to a line in contrib/oss-fuzz/Dockerfile. In fact this was at least building every day until libpng's configure.ac started producing a syntax error.

It is best to assure that the libpng oss-fuzz build is working properly, and check that the libpng read fuzzer is indeed doing something useful. I am not a recognized administrator for libpng oss-fuzz so I can not see details of oss-fuzz generated bug reports, but I see that at 'https://issues.oss-fuzz.com/issues?q=is:open%20libpng' there are three issues open, and one is recent (April 29, 2025), so it must have been working.

There is no need to torch the oss-fuzz builds.

@ctruta
Copy link
Member

ctruta commented Jun 11, 2025

@cristiano-masutti, see my other comment in PR #680.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants