Update the comparison to ProbNumDiffEq.jl#811
Merged
pnkraemer merged 1 commit intoApr 3, 2025
Conversation
Owner
|
Awesome, thanks for these updates! 😊 Let me know when this PR is ready to be reviewed. 👍 |
Owner
|
Hi :) The PR says it's still a draft, but the changes look pretty complete to me. Should we mark it as ready for review and start looking into merging it? |
Contributor
Author
|
Hi, sorry for the delayed response! I now marked the PR as ready for review, so please let me know if it needs additional changes or feel free to adjust it directly. |
pnkraemer
approved these changes
Apr 3, 2025
Owner
pnkraemer
left a comment
pnkraemer
left a comment
There was a problem hiding this comment.
Cheers man! I appreciate the updates :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProbNumDiffEq.jl implements state-space factorizations which make the EK0 and a diagonal version of the EK1 scale linearly with the dimension of the ODE. This PR therefore adjusts the comparison section of the probdifeq documentation to remove this aspect from the comparison, as nowadays ProbNumDiffEq.jl should behave quite similarly to probdiffeq and scale well with the problem size.