Skip to content

Remove Taylor-coefficient-scaling in doubling #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pnkraemer merged 1 commit into from
Sep 12, 2025
Merged

Remove Taylor-coefficient-scaling in doubling #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions probdiffeq/backend/functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ def jit(func, /, static_argnums=None, static_argnames=None):
return jax.jit(func, static_argnums=static_argnums, static_argnames=static_argnames)


def jet(func, /, primals, series):
return jax.experimental.jet.jet(func, primals=primals, series=series)
def jet(func, /, primals, series, *, is_tcoeff=False):
return jax.experimental.jet.jet(
func, primals=primals, series=series, factorial_scaled=not is_tcoeff
)


def linearize(func, *args):
Expand Down
6 changes: 3 additions & 3 deletions probdiffeq/taylor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,9 @@ def jet_embedded(*c, degree):
(compared to unnormalised coefficients).
"""
coeffs_emb = [*c] + [zeros] * degree
p, *s = _unnormalise(*coeffs_emb)
p_new, s_new = functools.jet(vf, (p,), (s,))
return _normalise(p_new, *s_new)
p, *s = coeffs_emb
p_new, s_new = functools.jet(vf, (p,), (s,), is_tcoeff=True)
return p_new, *s_new

taylor_coefficients = [u0]
degrees = list(itertools.accumulate(map(lambda s: 2**s, range(num_doublings))))
Expand Down