Skip to content

Feature/constraints check#164

Closed
abhyshr wants to merge 53 commits intodevelopfrom
feature/constraints-check
Closed

Feature/constraints check#164
abhyshr wants to merge 53 commits intodevelopfrom
feature/constraints-check

Conversation

@abhyshr
Copy link
Collaborator

@abhyshr abhyshr commented Jan 23, 2025

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • [ x] OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

  • DC line implementation for power flow and ACOPF.
  • Constraints check on infeasiblity/divergence
  • Updates to visualization : Zone visualization, removed flow layer, fixes, load loss.
  • Option to scale load.
  • Lazy line flow implementation
  • Need to add tests for DC line implementation.

abhyshr and others added 30 commits May 8, 2024 09:52
@abhyshr abhyshr requested a review from pelesh January 23, 2025 18:16
@pelesh pelesh added enhancement New feature or request opflow Concerning the OPFLOW application labels Jan 23, 2025
@pelesh
Copy link
Collaborator

pelesh commented Jan 31, 2025

I suggest merging #163 before this PR.

@pelesh pelesh mentioned this pull request Jan 31, 2025
15 tasks
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran tests for this branch on AMD EPYC/MI250X machine, and I saw following tests fail:

19/60 Test #19: FUNCTIONALITY_TEST_OPFLOW_RAJAHIOP_SPARSE_GPU_TOML_TESTSUITE .................***Failed    1.44 sec
      Start 20: FUNCTIONALITY_TEST_OPFLOW_IPOPT_POLAR_TOML_TESTSUITE
20/60 Test #20: FUNCTIONALITY_TEST_OPFLOW_IPOPT_POLAR_TOML_TESTSUITE .........................***Failed    5.60 sec
      Start 21: OPFLOW_MONITOR_KVLEVEL_IPOPT
21/60 Test #21: OPFLOW_MONITOR_KVLEVEL_IPOPT .................................................   Passed    1.36 sec
      Start 22: OPFLOW_LINEFLOW_PENALTY
22/60 Test #22: OPFLOW_LINEFLOW_PENALTY ......................................................***Failed    1.48 sec

Also, test FUNCTIONALITY_TEST_SCOPFLOW_HIOP_TESTSUITE. It seems it never leaves HiOp PriDec main loop.

@abhyshr, do you see all tests pass when you run them on your machine(s)?

CC @cnpetra @maksud @nkoukpaizan @nychiang

@pelesh
Copy link
Collaborator

pelesh commented Jan 31, 2025

The good news is there is only one test that hangs. The bad news is there are a few more other tests that fail:

86% tests passed, 8 tests failed out of 59

Label Time Summary:
incline-skip    =  61.81 sec*proc (2 tests)

Total Test time (real) = 304.59 sec

The following tests FAILED:
	 19 - FUNCTIONALITY_TEST_OPFLOW_RAJAHIOP_SPARSE_GPU_TOML_TESTSUITE (Failed)
	 20 - FUNCTIONALITY_TEST_OPFLOW_IPOPT_POLAR_TOML_TESTSUITE (Failed)
	 22 - OPFLOW_LINEFLOW_PENALTY (Failed)
	 32 - FUNCTIONALITY_TEST_SCOPFLOW_HIOP_PBHIOP_TESTSUITE (Failed)
	 33 - FUNCTIONALITY_TEST_SCOPFLOW_HIOP_PBHIOP_MPI_TESTSUITE (Failed)
	 34 - FUNCTIONALITY_TEST_SCOPFLOW_HIOP_MPI_TESTSUITE (Failed)
	 36 - FUNCTIONALITY_TEST_SCOPFLOW_HIOP_RAJA_TESTSUITE (Failed)
	 41 - FUNCTIONALITY_TEST_SOPFLOW_SCENARIO_TOML (Failed)

@abhyshr, do these tests pass on other machines?

@pelesh
Copy link
Collaborator

pelesh commented Jan 31, 2025

Looking at the output logs of some of these tests, it seems they are failing because of mismatched number of iterations to converged solution. This is probably not the best metric to use if the number of the iterations is >100.

@pelesh pelesh changed the title Draft:Feature/constraints check Feature/constraints check May 15, 2025
@pelesh pelesh requested review from maksud and nkoukpaizan May 15, 2025 19:20
@pelesh pelesh self-assigned this May 15, 2025
@nkoukpaizan nkoukpaizan force-pushed the feature/constraints-check branch 2 times, most recently from 410024b to a562bff Compare May 22, 2025 19:37
@nkoukpaizan nkoukpaizan mentioned this pull request May 22, 2025
20 tasks
@pelesh
Copy link
Collaborator

pelesh commented May 25, 2025

Closing this in favor of #166.

@pelesh pelesh closed this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request opflow Concerning the OPFLOW application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants