Add convert to STD205 application#133
Draft
wanhanlong1130 wants to merge 20 commits into
Draft
Conversation
lymereJ
reviewed
Sep 19, 2025
Collaborator
lymereJ
left a comment
lymereJ
left a comment
There was a problem hiding this comment.
@wanhanlong1130 - Thanks! Could you please convert the ipynb to py and integrate the whole process into one script so everything can be done at once. Also, could you please add the maps created from the curves?
* fixing interpolation bug with updated library * Add iteration loop. * updated library.json with some of York curves removed * removing multi_stage.json * remove new_lib.py not needed * unitarydirectexpansion_curves.json with updated library * deleted library.json and multi_stage.json * added speed attribute to each curve modifier * =Add unit test for MS unitary DX coil generation. --------- Co-authored-by: Lerond <jeremy.lerond@pnnl.gov> Co-authored-by: lymereJ <jeremy.lerond@gmail.com>
* fixing interpolation bug with updated library * Add iteration loop. * updated library.json with some of York curves removed * removing multi_stage.json * remove new_lib.py not needed * unitarydirectexpansion_curves.json with updated library * deleted library.json and multi_stage.json * added speed attribute to each curve modifier * =Add unit test for MS unitary DX coil generation. * Fix return for multi-speed fan configurations. --------- Co-authored-by: Rahman, Aowabin <aowabin.rahman@pnnl.gov>
lymereJ
requested changes
Oct 29, 2025
Collaborator
lymereJ
left a comment
lymereJ
left a comment
There was a problem hiding this comment.
It looks like main.py is not aligned with what you have on tanuki, could you please up it? Thanks!
| # Nominal values | ||
| nominal_capacity = 232057 # W | ||
| nominal_eer = 9.2 | ||
| nominal_eir = 1 / nominal_eer |
Collaborator
There was a problem hiding this comment.
@wanhanlong1130 EIR = 1 / COP and COP = EER /3.412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for review purpose.
All changes are in applications/ashrae205