-
Notifications
You must be signed in to change notification settings - Fork 339
Adds login through federated identity for Azure Devops. Closes #6649 #6670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds login through federated identity for Azure Devops. Closes #6649 #6670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for login via federated identity for Azure DevOps, while unifying the federated identity flow for both GitHub Actions and Azure DevOps.
- Updated the refined schema in the login command to recognize the new "federatedIdentity" auth type.
- Enhanced Auth.ts to retrieve and use federated tokens from both GitHub Actions and Azure DevOps, including support for service connections.
- Extended Auth.spec.ts with tests covering various scenarios for federated identity flows.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/m365/commands/login.ts | Updated options refinement to include federatedIdentity authentication type. |
src/Auth.ts | Added logic to handle federated identity flows for Azure DevOps, including service connection handling and token retrieval. |
src/Auth.spec.ts | New test cases covering Azure DevOps federated identity scenarios with and without service connections. |
b6220f5
to
6b005a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinlingstuyl awesome work 👏👏👏👏👏👏👏
Works like a charm unless you do not debug
😜
Leaving a comment as agreed over internal chat
let me know when it's ready for a recheck
Ok, I updated it and published a new beta package on martinlingstuyl. PLease do not forget checking if without service connection also works. And if github also still works :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge 🚀 |
Nice!! |
Merged manually. |
Closes #6649
Adds login through federated identity for Azure Devops.
The issue description contains how the setup works.
To test what's in this PR you can use my personal published CLI package:
You also need to create an Entra ID application with a federated credential. Check out the issue specs to know what to add there in terms of subject and issuer.