Remove graph api sdk dependency #1003

quails4Eva · 2024-04-01T11:12:22Z

Reduce dependency on Microsoft.Graph NuGet package
Based on discussion in #660
#660 (comment)

quails4Eva · 2024-04-01T11:13:47Z

src/lib/PnP.Framework/Graph/SubscriptionsUtility.cs

-                    var subscriptionModel = MapGraphEntityToModel(subscription);
-                    return subscriptionModel;
-                }).GetAwaiter().GetResult();
+                var response = JToken.Parse(responseAsString);


Converting string to Model seems like it could be an extension method?

Also tagging @KoenZomers as he wrote a lot of the original code

jansenbe · 2024-04-11T13:31:46Z

src/lib/PnP.Framework/Graph/SubscriptionsUtility.cs

-                    var subscriptionModel = MapGraphEntityToModel(subscription);
-                    return subscriptionModel;
-                }).GetAwaiter().GetResult();
+                var response = JToken.Parse(responseAsString);


@quails4Eva : would recommend using System.Text.Json over Newtonsoft

I think I've done this. I copied the newtonsoft code from elsewhere in the project, but I think this should be equivalent for system.text.json . It needed the package version updating for .net standard. I've changed it to use the same version for each target framework as I don't think system.text.json is tied to framework versions as some other packages are

quails4Eva · 2024-05-15T20:10:34Z

Next time I have some free time to look at this I'll try and replace the other usages in SubscriptionsUtility

quails4Eva · 2024-05-15T20:11:42Z

I started adding some async http bits to maintain where async was already being used, but then I realised that the async usage was all wrapped in Task.Run so probably not really helping anything. I can undo that if you'd rather it be put back.

quails4Eva · 2024-12-07T18:34:14Z

@jansenbe I'm looking at what's needed to replace the graph api sdk usage in the UsersUtility class and I think it would involve copying a bunch of dto classes from the graph sdk as currently these can be selected in as additional properties. I can do this, but I'm wondering how much value the methods on this class add as they just seem to be light wrappers over the underlying graph sdk methods? Would it make sense to just delete this class? Alternatively I could keep the methods, but remove the ability to select additional properties, as it seems to me like anyone doing that may as well just use the underlying graph sdk. I know this would be a breaking change, but it would save quite a bit of work and the methods don't seem like they add much to the framework, unless I'm missing something.

I've just used the System.Text.Json ability to store overflow properties in a dictionary, they'll be whatever type that uses. It's still a breaking change as the old version could return objects from the Graph Sdk, but not much that can be done about that when we're removing Graph Sdk.

matijahanzic · 2024-12-10T10:28:29Z

src/lib/PnP.Framework/PnP.Framework.csproj

MSGraph package reference is still in here, is this intended?

No, that was an oversight from me. I've removed it now.
I also removed Microsoft.Graph.Core and it still builds, though I can add that back in if it causes issues.

plamber · 2025-01-13T07:33:04Z

Hi @quails4Eva, @matijahanzic, @jansenbe,

While running an export of a Communication site template using the code below, we are now encountering the following failure:

```
public Stream? GetProvisioningTemplateStream(ClientContext context, Handlers handlers)
{
    handlers &= ~Handlers.SupportedUILanguages;
    handlers &= ~Handlers.PropertyBagEntries;
    handlers &= ~Handlers.SiteSecurity;
    handlers &= ~Handlers.WebSettings;
    handlers &= ~Handlers.SearchSettings;
    handlers &= ~Handlers.WebApiPermissions;
    handlers &= ~Handlers.Tenant;
    handlers &= ~Handlers.ExtensibilityProviders;
    handlers &= ~Handlers.ApplicationLifecycleManagement;
    handlers &= ~Handlers.SyntexModels;
    handlers &= ~Handlers.ImageRenditions;
    handlers &= ~Handlers.CustomActions;
    handlers &= ~Handlers.ComposedLook;
    handlers &= ~Handlers.Workflows;
    handlers &= ~Handlers.TermGroups;
    handlers &= ~Handlers.Publishing;
    handlers &= ~Handlers.Files;
    handlers &= ~Handlers.SiteFooter;
    handlers &= ~Handlers.Theme;

    ProvisioningTemplateCreationInformation creationInformation = new(context.Web)
    {
        PersistPublishingFiles = (handlers & Handlers.Pages) == Handlers.Pages,
        IncludeAllClientSidePages = (handlers & Handlers.Pages) == Handlers.Pages,
        HandlersToProcess = handlers,
        IncludeContentTypesFromSyndication = false,
    };

    context.RequestTimeout = Timeout.Infinite;
    return XMLPnPSchemaFormatter.LatestFormatter.ToFormattedTemplate(context.Web.GetProvisioningTemplate(creationInformation));
}
```

Error Message:

```
System.MissingMethodException: Method not found: 'PnP.Core.Model.SharePoint.IPage PnP.Core.Model.SharePoint.IWeb.NewPage(PnP.Core.Model.SharePoint.PageLayoutType, PnP.Core.Model.SharePoint.EditorType)'.

ObjectClientSidePages.ProvisionObjects(Web web, ProvisioningTemplate template, TokenParser parser, ProvisioningTemplateApplyingInformation applyingInformation)
SiteToTemplateConversion.ApplyRemoteTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation provisioningInfo, Boolean calledFromHierarchy, TokenParser tokenParser) line 457
WebExtensions.ApplyProvisioningTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation applyingInformation) line 1182
```

At this point, it’s unclear to me if this issue is related to the recent changes.

I’ll keep an eye out for any further details or patterns and update you if I find anything.

We were able to identify the issue causing this, I did a wrong reference of this PR my code. Sorry for the false alarm.

Cheers

tonipohl · 2025-01-13T17:26:50Z

So, when will this fix / update be available as PnP Nuget package? Checked today, Graph client is still included.
Asking for a friend. ;)
Thx, Toni

quails4Eva · 2025-03-08T10:41:11Z

@jansenbe @matijahanzic anything in particular that's needed to progress this pr? I don't have a great way to test the changes as my projects using PNP don't use these bits of the library. Most of my testing was using sample graph API responses and checking that it was converting to objects correctly.

Borgquite · 2025-03-10T10:38:05Z

It would be really helpful to merge this PR. I think it may resolve the long-standing problems when using Microsoft.Graph modules alongside PnP.PowerShell (a common requirement!)

pnp/powershell#3637
pnp/powershell#4476

matijahanzic · 2025-03-12T11:46:47Z

@jansenbe @matijahanzic anything in particular that's needed to progress this pr? I don't have a great way to test the changes as my projects using PNP don't use these bits of the library. Most of my testing was using sample graph API responses and checking that it was converting to objects correctly.

From my end, this looks good. I hope to see this merged soon. We also have issues using Microsoft Graph and PnP in our projects.

NivesBP · 2025-03-14T13:32:16Z

@jansenbe @matijahanzic anything in particular that's needed to progress this pr? I don't have a great way to test the changes as my projects using PNP don't use these bits of the library. Most of my testing was using sample graph API responses and checking that it was converting to objects correctly.

Hi @quails4Eva, @jansenbe can we help with the testing? Or do you need any other help to speed up this merge? :)

quails4Eva · 2025-04-15T22:07:39Z

@jansenbe @matijahanzic anything in particular that's needed to progress this pr? I don't have a great way to test the changes as my projects using PNP don't use these bits of the library. Most of my testing was using sample graph API responses and checking that it was converting to objects correctly.

Hi @quails4Eva, @jansenbe can we help with the testing? Or do you need any other help to speed up this merge? :)

I'm not familiar with the testing process/requirements for this repo, but I assume if you're able to test using this branch that would increase the confidence that the changes haven't broken anything.

MikeGitUser · 2025-04-25T22:47:14Z

How's it looking? Sure hope this is released soon! Still running PnP 1.12.0 due to the conflict with MgGraph. Really need some of the new features in the 2.x.0 release of PnP.

Please release soon!! :)

MikeGitUser · 2025-04-30T21:55:42Z

How's it looking? Sure hope this is released soon! Still running PnP 1.12.0 due to the conflict with MgGraph. Really need some of the new features in the 2.x.0 release of PnP.

Please release soon!! :)

Guessing this didn't make it in PnP 3.0.0? Does anyone know?

jansenbe · 2025-05-13T08:35:39Z

@quails4Eva / @Tanddant : I today took a look at this PR and tried to build it which failed due to the System.Text.Json.Nodes namespace not being available in the system.text.json version available for .NET Standard. Ideally the JSON handling for this PR needs be rewritten without needing the JsonNode class, alternative is using compiler directives to add an alternate code path for the .NET Standard distribution, but that will result in more code to maintain going forward.

I've added the System.Text.Json references like this:

	<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
                ...
		<PackageReference Include="System.Text.Json" Version="4.7.2" />
	</ItemGroup>	

	<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0' ">
                 ...
		<PackageReference Include="System.Text.Json" Version="8.0.5" />
	</ItemGroup>

	<ItemGroup Condition=" '$(TargetFramework)' == 'net9.0' ">
                  ...
		<PackageReference Include="System.Text.Json" Version="9.0.0" />
	</ItemGroup>

quails4Eva · 2025-05-13T20:52:52Z

@jansenbe is there a reason the .net standard package is targeting such an old version? The latest stj (System.text.json) supports .net standard.

I'm happy to be corrected, but I think that it should have one of the following.

All versions reference stj 8.x so they're consistent.
.net standard references stj 8.x and the framework versions have no dependency and use whatever comes with the framework.

I tried to find info on which of the above is best practice but only found dotnet/runtime#105014 which has some mixed messages.

quails4Eva · 2025-05-15T18:20:23Z

Also found this dotnet/runtime#110265 (comment) which suggests doing something like my suggestion 1, though I don't know how authoritative the answer is.

jansenbe · 2025-05-20T12:21:51Z

Think you're right @quails4Eva , seems there's a v9 version that's compatible with .NET framework. I'll do some testing to bump this in PnP Core SDK and PnP Framework. Once that works this PR can be probably be merged

quails4Eva added 2 commits April 1, 2024 12:08

Switch caught exception usage

2fbaeb4

Replace graph api sdk usage with http client usage

9626e86

quails4Eva commented Apr 1, 2024

View reviewed changes

quails4Eva mentioned this pull request Apr 1, 2024

Microsoft.Graph version issue #660

Open

jansenbe self-assigned this Apr 10, 2024

jansenbe reviewed Apr 11, 2024

View reviewed changes

jansenbe mentioned this pull request Apr 11, 2024

[ DO-NOT-MERGE-YET] Update to the Graph SDK v5 #859

Draft

quails4Eva added 9 commits May 15, 2024 19:51

Update version of System.Text.Json used

d3867f1

Replace Newtonsoft.Json with system.text.json

22297cc

Update Microsoft.Bcl.AsyncInterfaces

280db1d

Re-use existing item group

5c1b2ff

Replace some graph api exception usage

c0098e4

Add async version of MakeHttpRequest

6c45fdf

Replace a delete group usage

c137c80

Throw more specific exception when http error

014dd41

Replace delete call

68c6983

quails4Eva added 12 commits May 27, 2024 12:43

CreateSubscription to use http client

c7f922f

Update patch

d6a3e24

Update delete

5e8d822

Update ListSubscriptions

32e7b28

Implement range selection

f2cc5f7

Remove unused async -> sync

6c7acc9

Add todo

e30cd74

Replace graph api usage

d8d503c

fix build issue

1484fbc

Fix build issue

4cffde9

.

8d979cf

Remove some graph api usage

a1b75ba

quails4Eva added 6 commits December 7, 2024 16:47

Remove unused code

6099479

ListUsers to not use MS Graph Api SDK

3cdc1a1

Fix start and end index

6df9841

Replace use of MS Graph Api SDK

5355b6f

Remove PnPHttpProvider

6a3d2e9

Re-use json options

b0ceb5c

quails4Eva added 2 commits December 7, 2024 18:53

Merge

2372b67

Remove extra package added

a5d6613

quails4Eva marked this pull request as ready for review December 7, 2024 18:59

plamber mentioned this pull request Jan 10, 2025

Provider.GetTemplate() returns Unable to load one or more of the requested types. WHEN together with Graph SDK 5 #1042

Open

matijahanzic reviewed Jan 10, 2025

View reviewed changes

quails4Eva added 3 commits January 11, 2025 14:38

Remove Microsoft.Graph package

81db6cc

Minor updates

47a75b0

Remove Microsoft.Graph.Core

281de1f

quails4Eva changed the title ~~Start trying to remove graph api sdk dependency~~ Remove graph api sdk dependency May 1, 2025

jansenbe merged commit 0ae8bd2 into pnp:dev May 20, 2025

Remove graph api sdk dependency #1003

Remove graph api sdk dependency #1003

Uh oh!

Conversation

quails4Eva commented Apr 1, 2024

Uh oh!

quails4Eva Apr 1, 2024

Choose a reason for hiding this comment

Uh oh!

jansenbe Apr 11, 2024

Choose a reason for hiding this comment

Uh oh!

jansenbe Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quails4Eva May 15, 2024

Choose a reason for hiding this comment

Uh oh!

quails4Eva commented May 15, 2024

Uh oh!

quails4Eva commented May 15, 2024

Uh oh!

quails4Eva commented Dec 7, 2024

Uh oh!

matijahanzic Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

quails4Eva Jan 11, 2025

Choose a reason for hiding this comment

Uh oh!

plamber commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonipohl commented Jan 13, 2025

Uh oh!

quails4Eva commented Mar 8, 2025

Uh oh!

Borgquite commented Mar 10, 2025

Uh oh!

matijahanzic commented Mar 12, 2025

Uh oh!

NivesBP commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quails4Eva commented Apr 15, 2025

Uh oh!

MikeGitUser commented Apr 25, 2025

Uh oh!

MikeGitUser commented Apr 30, 2025

Uh oh!

jansenbe commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quails4Eva commented May 13, 2025

Uh oh!

quails4Eva commented May 15, 2025

Uh oh!

jansenbe commented May 20, 2025

Uh oh!

Uh oh!

jansenbe Apr 11, 2024 •

edited

Loading

plamber commented Jan 13, 2025 •

edited

Loading

NivesBP commented Mar 14, 2025 •

edited

Loading

jansenbe commented May 13, 2025 •

edited

Loading