Skip to content

Enable Provisioning of Shared Teams Channels #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singingknight wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Enable Provisioning of Shared Teams Channels #1128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectTeams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,16 +1061,22 @@ private static string CreateTeamChannel(PnPMonitoredScope scope, Model.Teams.Tea
// Temporary variable, just in case
List<String> channelMembers = null;

if (channel.Private)
var privateOrSharedChannel = channel.MembershipType == MembershipType.Private || channel.MembershipType == MembershipType.Shared;
if (privateOrSharedChannel)
{
// Get the team owners, who will be set as members of the private channel
// if the channel is private
// Get the team owners, who will be set as owners of the channel
// if the channel is private or shared (only first owner if shared)
var teamOwnersString = HttpHelper.MakeGetRequestForString($"{graphBaseUri}v1.0/groups/{teamId}/owners", accessToken);
channelMembers = new List<String>();

foreach (var user in JObject.Parse(teamOwnersString)["value"] as JArray)
{
channelMembers.Add((string)user["id"]);
if (channel.MembershipType == MembershipType.Shared)
{
// Only add the first owner if the channel is shared
break;
}
}
}

Expand All @@ -1081,21 +1087,21 @@ private static string CreateTeamChannel(PnPMonitoredScope scope, Model.Teams.Tea
{
description = parser.ParseString(channel.Description),
displayName = parser.ParseString(channel.DisplayName),
isFavoriteByDefault = channel.Private ? false : channel.IsFavoriteByDefault,
membershipType = channel.Private ? "private" : "standard",
moderationSettings = channel.Private ? null : new Dictionary<string, object>{
isFavoriteByDefault = privateOrSharedChannel ? null : channel.IsFavoriteByDefault,
membershipType = channel.MembershipType.ToString().ToLowerInvariant(),
moderationSettings = privateOrSharedChannel ? null : new Dictionary<string, object>{
{ "userNewMessageRestriction", channel.UserNewMessageRestriction },
{ "replyRestriction", channel.ReplyRestriction },
{ "allowNewMessageFromBots", channel.AllowNewMessageFromBots },
{ "allowNewMessageFromConnectors", channel.AllowNewMessageFromConnectors }
},
members = (channel.Private && channelMembers != null) ? (from m in channelMembers
select new
{
private_channel_member_odata_type = "#microsoft.graph.aadUserConversationMember",
private_channel_user_odata_bind = $"{graphBaseUri}v1.0/users('{m}')",
roles = new String[] { "owner" }
}).ToArray() : null
members = channelMembers != null ? (from m in channelMembers
select new
{
private_channel_member_odata_type = "#microsoft.graph.aadUserConversationMember",
private_channel_user_odata_bind = $"{graphBaseUri}v1.0/users('{m}')",
roles = new String[] { "owner" }
}).ToArray() : null
};

var channelId = GraphHelper.CreateOrUpdateGraphObject(scope,
Expand Down