-
Notifications
You must be signed in to change notification settings - Fork 26
Feat - Feedback using microsoft forms Closes #571 #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Feat - Feedback using microsoft forms Closes #571 #602
Conversation
@nirav-raval thanks for opening the PR. I will try to give it a check ASAP. |
lets hold with the merge until the #610 gets solved |
8660733
to
edb2abd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirav-raval solid work πͺ
I left only some small comments to clean up the PR and improve the maintainability of the change.
Let's get this fixed up before we merge π
You Rock π€©
@nirav-raval to address VSCode marketplace issues (you may read more about it here #610) we were force to do a standard minor release of this product. |
@nirav-raval just wanted to catch up. Is there anything I may help you with this PR to get you unblocked. |
@Adam-it Thanks for the offer! I am planning to go through this over this weekend! I'll keep you posted. |
03b0937
to
1560506
Compare
Force pushed to dev because of conflicts. Will push the changes soon and open this Issue! |
@nirav-raval thanks for the quick turnaround. I will try to look at it ASAP π |
π― Aim
Integrate a feedback survey into the SPFx Toolkit extension to gather input from users
π· Result
β What was done
vscode-extension-feedback
packageπ Related issue
Closes: #571