Skip to content

Conversation

nirav-raval
Copy link
Contributor

🎯 Aim

Integrate a feedback survey into the SPFx Toolkit extension to gather input from users

πŸ“· Result

feedback

βœ… What was done

  • Added integration with vscode-extension-feedback package
  • Configured feedback notification to display within the extension
  • Linked survey to Microsoft Forms (https://forms.office.com/e/ZTfqAissqt)

πŸ”— Related issue

Closes: #571

@nirav-raval nirav-raval changed the base branch from main to dev October 3, 2025 00:14
@nirav-raval nirav-raval marked this pull request as ready for review October 3, 2025 00:25
@nirav-raval
Copy link
Contributor Author

There's no error locally not sure why test fails!!!

image image image

@Adam-it Adam-it self-assigned this Oct 3, 2025
@Adam-it
Copy link
Member

Adam-it commented Oct 3, 2025

@nirav-raval thanks for opening the PR. I will try to give it a check ASAP.
Don't worry about the tests. If you think it should be ok I will give it a recheck as well πŸ‘πŸ‘πŸ‘
You Rock 🀩

@Adam-it
Copy link
Member

Adam-it commented Oct 4, 2025

lets hold with the merge until the #610 gets solved
@nirav-raval don't worry about the Hacktoberfest. When we review it, we will mark this PR with hacktoberfest-accepted label so it will count towards your contributions for the event without merging
That is also the reason why the tests fail on this PR so also don't worry about this

@Adam-it Adam-it force-pushed the Feat-feedback-using-Microsoft-Forms branch from 8660733 to edb2abd Compare October 5, 2025 21:40
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirav-raval solid work πŸ’ͺ
I left only some small comments to clean up the PR and improve the maintainability of the change.
Let's get this fixed up before we merge πŸ‘
You Rock 🀩

@Adam-it Adam-it marked this pull request as draft October 5, 2025 22:19
@Adam-it
Copy link
Member

Adam-it commented Oct 7, 2025

@nirav-raval to address VSCode marketplace issues (you may read more about it here #610) we were force to do a standard minor release of this product.
During our release process, the main branch is aligned with dev branch. Your changes are now based on the old version of dev branch, which is not aligned with the repo.
May I kindly ask you to align your dev branch on your forked repo and rebase the branch for this PR before we proceed with the review. Let me know if you will need any kind of help with that.
There are also some review comments that need to be addressed above πŸ‘†
Sorry for the problem

@Adam-it
Copy link
Member

Adam-it commented Oct 9, 2025

@nirav-raval just wanted to catch up. Is there anything I may help you with this PR to get you unblocked.
Do you want to perform the rebase or recheck the review comments?

@nirav-raval
Copy link
Contributor Author

@Adam-it Thanks for the offer! I am planning to go through this over this weekend! I'll keep you posted.

@nirav-raval nirav-raval force-pushed the Feat-feedback-using-Microsoft-Forms branch from 03b0937 to 1560506 Compare October 13, 2025 04:58
@nirav-raval
Copy link
Contributor Author

Force pushed to dev because of conflicts. Will push the changes soon and open this Issue!

@nirav-raval nirav-raval reopened this Oct 13, 2025
@nirav-raval nirav-raval marked this pull request as ready for review October 13, 2025 05:20
@Adam-it
Copy link
Member

Adam-it commented Oct 13, 2025

@nirav-raval thanks for the quick turnaround. I will try to look at it ASAP πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collect feedback on SPFx Toolkit using Microsoft Forms

2 participants