Skip to content

fix: not allow install multiple package manager #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

BlackHole1
Copy link
Member

@BlackHole1 BlackHole1 commented Mar 25, 2025

When a project has both npm and pnpm, using pnpm/action-setup will result in an error: Multiple versions of pnpm specified.

The previous implementation was only meant to avoid the ERR_PNPM_BAD_PM_VERSION error, but it did not take into account the situation of multiple different package managers.

My project structure:

/root
	package.json
		packageManger: npm@XXX

	sub-proj
		package.json
			packageManger: pnpm@YYY

When a project has both npm and pnpm, using pnpm/action-setup will result in an error: `Multiple versions of pnpm specified`.

The previous implementation was only meant to avoid the "ERR_PNPM_BAD_PM_VERSION" error, but it did not take into account the situation of multiple different package managers.

Signed-off-by: Kevin Cui <[email protected]>
@BlackHole1 BlackHole1 requested review from zkochan and KSXGitHub March 25, 2025 11:26
@BlackHole1 BlackHole1 merged commit d648c2d into pnpm:master Mar 28, 2025
75 of 81 checks passed
@BlackHole1 BlackHole1 deleted the fix-err branch March 28, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants