feat!: bundle template files as 1 json file #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow the pnpm build script to stop copying the template files from this library to pnpm's `dist` assuming the bundle script used by pnpm can bundle JSON. BREAKING CHANGE: `getCompletionScript` no longer returns a `Promise`
|
What is the benefit of this approach? |
|
The location of the template files is an implementation details. Bundlers shouldn't need to know this location. This PR would convert the template files from static assets that need to be manually read with |
|
ok, but we already have this configured for pnpm or is this change for other consumers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow the pnpm build script to stop copying the template files from this library to pnpm's
distassuming the bundle script used by pnpm can bundle JSON.BREAKING CHANGE:
getCompletionScriptno longer returns aPromise