Parse callouts#391
Open
JanEricNitschke wants to merge 12 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements enhancements for parsing callouts and improves handling of VPhys data, including optional in-memory input and additional filtering options. Key changes:
- Added to_dict/from_dict for Triangle in awpy/visibility.py.
- Updated VphysParser to support in-memory VPhys data and new flags (including_player_clippings and include_everything).
- Introduced a new module, awpy/callout.py, and integrated a new CLI command for parsing callouts.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| awpy/visibility.py | Added dictionary conversion methods for Triangle and extended VphysParser API. |
| awpy/vector.py | Added scalar division and multiplication operators for Vector3. |
| awpy/cli.py | Updated CLI commands and parameters to support new VPhysParser options and callouts. |
| awpy/callout.py | Introduced callout parsing from vents and PHYS blocks with JSON serialization. |
| awpy/init.py | Updated all to expose the new Callout module. |
Files not reviewed (2)
- scripts/generate-callouts.ps1: Language not supported
- scripts/generate-tris.ps1: Language not supported
Comments suppressed due to low confidence (1)
awpy/visibility.py:286
- [nitpick] Consider renaming 'include_everything' to a more descriptive name, such as 'include_all_meshes_and_hulls', to clearly indicate its purpose.
include_everything: bool = False,
There was a problem hiding this comment.
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (2)
- scripts/generate-tris.ps1: Language not supported
- scripts/generate-volumes.ps1: Language not supported
Comments suppressed due to low confidence (2)
awpy/plantzone.py:80
- The docstring in the from_dict method mistakenly refers to 'Bomnbsite' instead of 'Plantzone'. Please update the type reference to match the class name.
Bomnbsite: plantzone object created from the dictionary.
awpy/buyzone.py:73
- The docstring incorrectly states that it converts to a Callout object; it should reference a Buyzone object instead.
"""Convert a dictionary to a Callout object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #390
Based on #376
Example test could be like:
Also still needs to be integrated into the artifact handling.