-
Notifications
You must be signed in to change notification settings - Fork 13
Fixed Main.c #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Advaitgaur004
wants to merge
18
commits into
pocketpy:main
Choose a base branch
from
Advaitgaur004:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed Main.c #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l weight initialization
…ove unused random fill function
…n tensor operations
…null inputs and adjust softmax cross-entropy integration
…utput and maintain memory allocation order
…eight initialization
…ain.c to utilize this new function
Reason : With MSVC compiler...One will seeing consistent -431602080.0000 values (likely MSVC's debug heap initialization pattern) The key problem is that after allocating memory for the tensor data, the code doesn't initialize the actual floating-point values. It only sets the numel field of the FloatBuffer structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements proper fixes and enhancements to the neural network library, with a focus on correcting the main.c training loop and gradient computation.
Changes
Core Operations
Tensor_transpose
function for matrix transpositionGradFn_matmul
to properly handle gradient computation using transpositionTensor_sub
operation with appropriate gradient functionsNeural Network Components
nn_random_init
function implementing Xavier/Glorot initializationLoss Functions
nn_crossentropy
to avoid numerical issues by adding epsilonnn_softmax_crossentropy
to stabilize trainingTraining Improvements
Memory Management