Feature/update client - #10
Merged
Merged
Conversation
…penser more robust and allow user to change client_id for all tokens
yenes56
approved these changes
Mar 5, 2026
yenes56
added a commit
that referenced
this pull request
Mar 27, 2026
* Miscellaneous Fixes/Cleanup (#2) * Fix examples * Move outputs.tf to proper location * Ignore .tfplan files * Loosen terraform version constraint * TokenDispenserMinimumAccess policy * Terraform helper commands * Enable x86 builds on arm64 * Simplify build process * Update README.md with terraform instructions * Readme typo * Make lambda throw an explicit error to catch on client lib (#3) * move launchpad_token.py out of aws directory (#4) authored by: David Yen <david.yen@jpl.nasa.gov> * Feature/podaac 6884 (#5) * added cloudtrail * created s3 bucket policy for the cloudtrail logging bucket * unused code cleanup * comments cleanup * use aws_iam_role_policy instead of aws_iam_role_policy_attachment * direct reference the cloudtrail s3 bucket arn. * code cleaning and turn on cloudtrail management event logging * set default log rentention days to 180 * remove retention days from example.tfvars * set log management event to false --------- Co-authored-by: David Yen <david.yen@jpl.nasa.gov> * Feature/podaac 6884 (#6) * added cloudtrail * created s3 bucket policy for the cloudtrail logging bucket * unused code cleanup * comments cleanup * use aws_iam_role_policy instead of aws_iam_role_policy_attachment * direct reference the cloudtrail s3 bucket arn. * code cleaning and turn on cloudtrail management event logging * set default log rentention days to 180 * remove retention days from example.tfvars * set log management event to false * append random string in the end of cloudtrail bucket name to keep s3 bucket name unique * prevent lifecycle destroy --------- Co-authored-by: David Yen <david.yen@jpl.nasa.gov> * add EDL token storage/retrieval on new action event (#7) * add EDL token storage/retrieval on new action event * pushed EDL token toi DB with 120s lifespan * using epoche+120 for EDL token expiration * extend token expiration if expiration < 24 hours * Update token_dispenser_lambda.py for EDL expires_at --------- Co-authored-by: DavidVWood44 <david.v.wood@nasa.gov> * update get_edl_token function (#8) * update get_edl_token function * update get_edl_token function * update get_edl_token function call (#9) * Add automatic project assignment workflow This workflow automatically: - Adds new issues and PRs to the podaac project - Sets their status to 'needs:triage' Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Feature/update client (#10) * update get_edl_token function call * update token dispenser client_id for all tokens, this should make dispenser more robust and allow user to change client_id for all tokens * Add automatic team/project assignment workflow This workflow automatically, when team label is assigned to an issue: - Set podaac project status to triage - Assign to the team github project when it exists, with a New status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add automatic team/project assignment workflow This workflow automatically, when team label is assigned to an issue: - Set podaac project status to triage - Assign to the team github project when it exists, with a New status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * make release 2.0.0 --------- Co-authored-by: Josh Garde <joshgarde@gmail.com> Co-authored-by: David Yen <david.yen@jpl.nasa.gov> Co-authored-by: DavidVWood44 <david.v.wood@ama-inc.com> Co-authored-by: DavidVWood44 <david.v.wood@nasa.gov> Co-authored-by: Simon Liu <69875423+sliu008@users.noreply.github.com> Co-authored-by: thomas loubrieu <60993872+tloubrieu-jpl@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Closed
viviant100
pushed a commit
that referenced
this pull request
Mar 27, 2026
* update get_edl_token function call * update token dispenser client_id for all tokens, this should make dispenser more robust and allow user to change client_id for all tokens
viviant100
pushed a commit
that referenced
this pull request
Mar 27, 2026
* update get_edl_token function call * update token dispenser client_id for all tokens, this should make dispenser more robust and allow user to change client_id for all tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the logic for determining the
client_idin thehandlerfunction oftoken_dispenser/token_dispenser_lambda.py. The special handling for the"edl"action has been removed, so nowclient_idis always taken directly from the event.client_idassignment logic in thehandlerfunction by removing conditional logic for the"edl"action;client_idis now always set fromevent.get('client_id').