Conversation
hkryeung
requested changes
Jun 17, 2026
Contributor
|
Hi @DavidVWood44 , can you look at @hkryeung comment ? |
Contributor
|
Hi @DavidVWood44 , @DavidVWoodSr , any updates on this PR ? |
Collaborator
Author
|
@hkryeung/@tloubrieu-jpl |
Contributor
|
Hi @hkryeung, could you re-review the PR ? Thanks |
hkryeung
requested changes
Jul 28, 2026
| edl_user: str, | ||
| edl_pass: str, | ||
| edl_env: str, | ||
| return_type: Literal["raw", "json", "bearer"] = "bearer", |
Contributor
There was a problem hiding this comment.
Considering the first version of the code was returning json by default, please have it do so
return_type: Literal["raw", "json", "bearer"] = "json"
(so if other teams don't have it set, it wouldn't break their code)
https://github.com/podaac/token-dispenser/pull/16/changes#diff-de455c0409f38aa6759eac2653767e3ab85e50f9bc05778f49848a5a492e0999L169
Collaborator
Author
There was a problem hiding this comment.
@hkryeung , I have defaulted the get_edl_token return type to json. Please review. Thx...
hkryeung
approved these changes
Jul 28, 2026
yenes56
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15
aded return token to EDL using {Auth...: Bearer } as requested by bignbit