fix: lax strictness of scope, strategy #244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing a new strategy or scope should not always be a breaking change for clients, like `shadow-dom`.
digitalsadhu
reviewed
Nov 7, 2024
Member
digitalsadhu
left a comment
digitalsadhu
left a comment
There was a problem hiding this comment.
I'm on the fence here. I think this makes good sense, especially if we expect to be changing the valid values of these fields. Thing is, this won't solve the current issue since it would need to be added to the client/layout so can only solve the issue for the future. And Im really not sure this value would be very likely to change again any time soon...
|
what I'm wondering about is why are we having the validation of the podlet schema in the Layout if we think that saying "as long as it's a string its fine" is ok. what's the purpose of this validation? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new strategy or scope should not always be a breaking change for clients, like
shadow-dom.