Fix misc. warnings#667
Merged
Merged
Conversation
github-actions
Bot
added
storage
|
Packit jobs failed. @containers/packit-build please check. |
2 similar comments
|
Packit jobs failed. @containers/packit-build please check. |
|
Packit jobs failed. @containers/packit-build please check. |
Contributor
|
/packit rebuild-failed |
|
Account lsm5 has no write access nor is author of PR! |
lsm5
approved these changes
Feb 19, 2026
lsm5
left a comment
lsm5
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I cannot restart packit jobs here, so one of the admins can retry using my comment above.
Member
|
cross builds are failing |
kolyshkin
reviewed
Feb 23, 2026
| } | ||
|
|
||
| func handleLChmod(hdr *tar.Header, path string, hdrInfo os.FileInfo, forceMask *os.FileMode) error { | ||
| func handleLChmod(_ *tar.Header, _, _ string, _ os.FileInfo, _ *os.FileMode) error { |
Contributor
There was a problem hiding this comment.
This is the issue ^^^ (extra string argument) which causes cross job to fail on Windows
kolyshkin
reviewed
Feb 23, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Contributor
There was a problem hiding this comment.
Also, in cases all arguments are unused, you can omit _ entirely. E.g.:
-func resetImmutable(_ string, _ *os.FileInfo) error {
+func resetImmutable(string, *os.FileInfo) error {
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
kolyshkin
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is annoying me in an IDE, let’s clean that up.