ci: Mac CI with self-hosted runner for machine tests#4
Open
timcoding1988 wants to merge 3 commits into
Open
Conversation
0437fa6 to
d3856a0
Compare
ashley-cui
reviewed
May 26, 2026
Comment on lines
+93
to
+97
| - name: Build podman + ginkgo + mac-helper | ||
| run: | | ||
| make .install.ginkgo | ||
| make podman-remote | ||
| make podman-mac-helper |
Contributor
There was a problem hiding this comment.
would it be better to install the binaries built from the build task? this seems like duplicate work
| @@ -0,0 +1,15 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
We can leave this for now, but I think once we set up the github runner, there are pre-and post run hooks we can specify to clean the vm after runs.
Author
There was a problem hiding this comment.
correct. think we can remove this
Comment on lines
+7
to
+14
| - '.github/workflows/mac.yml' | ||
| - 'cmd/**' | ||
| - 'pkg/**' | ||
| - 'libpod/**' | ||
| - 'contrib/pkginstaller/**' | ||
| - 'Makefile' | ||
| - 'go.mod' | ||
| - 'go.sum' |
Contributor
There was a problem hiding this comment.
I think the original conditional in cirrus is
PR title has [CI:ALL]
Or one of these files is changed:
- .cirrus.yml (probably should be updated to /.github/workflows/mac.yml)
- Makefile
- contrib/cirrus/** (Update to contrib/gha/mac/*)
- vendor/**
- test/tools/**
- test/registries*.conf
- hack/**
- version/rawversion/*
- cmd/podman/machine/**
- pkg/machine/**
- **/machine.go
ec5c99d to
0134d0f
Compare
Signed-off-by: Tim Zhou <tizhou@redhat.com>
0134d0f to
065dd2b
Compare
Pins runs-on to the MacM1-4 label so both matrix arms execute on a single known-good host. max-parallel: 1 since both providers now share one runner. Signed-off-by: Tim Zhou <tizhou@redhat.com>
Signed-off-by: Tim Zhou <tizhou@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using self host mac for the mac tests