Add lstocchi as Podman Reviewer#28568
Merged
Merged
Conversation
Luca remarkable knowledge of the Windows virtualization platform would be beneficial for reviewing PRs and triaging issues. lstocchi contributions: - podman-container-tools#28535 - podman-container-tools#27932 - podman-container-tools#27931 - podman-container-tools#27885 - podman-container-tools#27650 - podman-container-tools#26277 - podman-container-tools#26201 - podman-container-tools#20478 Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Contributor
|
Thank you! It would be an honor to become a reviewer for this project. I am happy to accept the role and help you on the Windows side!! |
Contributor
|
LGTM Per governance, two maintainers concurring is enough to approve. I'm going to merge. |
Member
|
Process wise it would be nice if we could at least cc all maintainers on such PRs. Not that I have any objections but it is nice to know (officially) when we onboard new members. cc @containers/podman-maintainers Welcome @lstocchi, our main developer chat is on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luca remarkable knowledge of the Windows virtualization platform would be beneficial for reviewing PRs and triaging issues.
His contributions to the Podman repository during the last six months:
@lstocchi as per the https://github.com/containers/podman/blob/main/GOVERNANCE.md you need to add a comment to this PR indicating your willingness to assume the responsibilities of a Reviewer.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?