Test fixes/skips for new CI system#28794
Merged
Merged
Conversation
Contributor
|
The Mac OS X failure is rather interesting
So it looks like
This is what podman-container-tools/podman-sandbox#9 does (among the other things). The checkout path is also fixed in there. As a stop-gap measure, I propose #28797. |
It is not working in all ipv6 setups. In the new lima testing env default_addr is just null causing the test to fail because the container address was "fec0::5055:55ff:fe2b:6cc9". For now skip this until we can figure something better out. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The test assumed /home/$USER == $HOME which may not be the case. In fact it is not the case in the new lima VM runners. Fix the test to actually use the path we want to test for, $HOME. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The test assumes a local id_ed25519 ssh key exists and is setup to connect to its own user. That is basically never the case locally so the test is broken by design. If the test should run in some special CI setup where that is the case we need to enable it and guard based on that later. For now I just like to get the lima VM tests passing. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The container prints "Failed to set RLIMIT_CORE: Operation not permitted" I do not know why this fails when run with sudo but lets just skip it it for now. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This is really not nice but it is a quick fix to avoid more flakes. The 10.11.12.0/24 was used by several tests and podman will only allow the network to be created once with a given subnet so we need to ensure they are conflict free, otherwise in parallel runs they will fail randomly. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
I saw this already in openQA and now with the new rawhide images we hit it in upstream as well. Skip this for now to not cause so many flakes. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This seems to flake in the parallel CI runs as another process might also use 8080 already. We can use any port here so use GetPort() which should give us a conflict free one. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
In highly parallel runs this can fail its timeout due the fact that we run podman ps -a which takes all contianer locks, even the ones from unrelated tests. thus this command can take a long time, from a CI log I see: [18:22:30.932958589] # /var/tmp/podman/bin/podman ps -a [18:22:34.338904713] CONTAINER ID IMAGE So like a 4s delay just on that and hence the test later failed with "Operations took too long" as it took 7 seconds overall. So since we know podman inspect takes the lock just keep that and not try to get all containers for no reason. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This is a long standing flake but I see it again in the lima CI, the problem seems to happen when we stop the container before the background healthcheck fires. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
podman ps -a causes unexpected timing delays as it tries to take locks for all containers and parallel tests may cause it to block for a while. In CI logs I see ps -a take over 3 seconds which is enough to mess with the expect time and make the test fail. Since testing the ps -a output as part of the test just switch the test to not run in parallel. This failed with "delta t between paused and restarted" where it took 10 seconds instead of the max expected 6 seconds. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Contributor
|
LGTM |
ashley-cui
merged commit 93a5199
into
podman-container-tools:main
72 of 73 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commits, all of these were found in my initial lima work in podman-container-tools/podman-sandbox#5
Does this PR introduce a user-facing change?