Skip to content

machine: share virtiofs systemd unit generation#28823

Open
inknos wants to merge 1 commit into
podman-container-tools:mainfrom
inknos:run-4472
Open

machine: share virtiofs systemd unit generation#28823
inknos wants to merge 1 commit into
podman-container-tools:mainfrom
inknos:run-4472

Conversation

@inknos
Copy link
Copy Markdown
Collaborator

@inknos inknos commented Jun 1, 2026

Make GenerateSystemDFilesForVirtiofsMounts an agnostic function and move the code from apple to pkg/machine/volume_systemd.go.

MountVolumesToVM is now a no-op matching the AppleHV and LibKrun behaviour.

Continues from PR: #28736

Fixes: https://redhat.atlassian.net/browse/RUN-4742

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Make GenerateSystemDFilesForVirtiofsMounts an agnostic function
and move the code from apple to pkg/machine/volume_systemd.go.

MountVolumesToVM  is now a no-op matching the AppleHV and
LibKrun behaviour.

Continues from PR: podman-container-tools#28736

Fixes: https://redhat.atlassian.net/browse/RUN-4742

Signed-off-by: Nicola Sella <nsella@redhat.com>
@inknos
Copy link
Copy Markdown
Collaborator Author

inknos commented Jun 1, 2026

Note, with this change the existing machines will have to be stopped, removed and recreated, since they won't have the correct systemd files at init time. Is it considered a breaking change or just workaroundable? @baude @Honny1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant