CI migration#2883
Conversation
Mirrors validate, doccheck, cross, osx, test_skopeo, and ostree_rs_ext from containers/skopeo's .cirrus.yml into a GH Actions workflow on podman-io/skopeo-sandbox. Signed-off-by: Tim Zhou <tizhou@redhat.com>
Signed-off-by: Tim Zhou <tizhou@redhat.com>
Signed-off-by: Tim Zhou <tizhou@redhat.com>
| runs-on: oracle-vm-4cpu-16gb-x86-64 | ||
| timeout-minutes: 45 | ||
| container: | ||
| image: quay.io/libpod/skopeo_cidev:${{ vars.IMAGE_TAG }} |
There was a problem hiding this comment.
Mirroring the sandbox repo, I have defined https://github.com/podman-container-tools/skopeo/settings/variables/actions/IMAGE_TAG .
But we definitely need that to be per-branch, and preferably Renovate-managed.
There was a problem hiding this comment.
… that doesn’t work because repo variables are not available in pull requests.
I tried using env: at the top level of the workflow and ${{ env. }} in these places, but that doesn’t recognize env.. I might well be doing something dumb.
So I just hard-coded the tag for now.
mtrmac
force-pushed
the
ci-draft
branch
2 times, most recently
from
3ceafe1 to
e3f3809
Compare
|
For future maintenance: Note also comments in podman-container-tools/skopeo-sandbox#1 and podman-container-tools/skopeo-sandbox#9 . |
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| path-filter: |
There was a problem hiding this comment.
I am ok with dropping this here, I agree the complexity is not worth it on skopeo
The POC used a repo settings variable, but that doesn't work for pull requests; and it would be hard to maintain with branches. Sadly, there seems to be no easy facility to define a file-wide constant in GitHub actions, so hard-code three copies. Hopefully Renovate can be set up to update this, then the number of copies won't matter. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
Marking ready for review now. |
|
LGTM |
3 participants
This is a copy of podman-container-tools/skopeo-sandbox#9 .