Skip to content

fix: resolve GHSA-qhr7-859c-m2p7 in brace-expansion - #1409

Merged
benoitf merged 1 commit into
podman-desktop:mainfrom
benoitf:cve-fix/ghsa-qhr7-859c-m2p7-main
Sep 30, 2026
Merged

benoitf merged 1 commit into
podman-desktop:mainfrom
benoitf:cve-fix/ghsa-qhr7-859c-m2p7-main

Conversation

@benoitf

@benoitf benoitf commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix high severity vulnerability GHSA-qhr7-859c-m2p7 in brace-expansion.

Advisory: brace-expansion: DoS via uncontrolled recursion on nested brace groups causing stack exhaustion
Vulnerable versions: <1.1.20
Patched versions: >=1.1.20
Advisory URL: GHSA-qhr7-859c-m2p7

Screenshot / video of UI

N/A - dependency update only.

What issues does this PR fix or reference?

Fixes GHSA-qhr7-859c-m2p7: brace-expansion: DoS via uncontrolled recursion on nested brace groups causing stack exhaustion

How to test this PR?

Run pnpm audit and verify GHSA-qhr7-859c-m2p7 is no longer reported

Upgrade brace-expansion to satisfy >=1.1.20
Advisory: GHSA-qhr7-859c-m2p7

Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
benoitf requested a review from a team as a code owner September 30, 2026 08:23
@benoitf
benoitf requested review from axel7083, cdrage and feloy and removed request for a team September 30, 2026 08:23
@benoitf
benoitf enabled auto-merge (rebase) September 30, 2026 08:23
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: cd9e4401-492a-476d-a242-7c5f543a2c1b

📥 Commits

Reviewing files that changed from the base of the PR and between 549af78 and a6825e9.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workspace updates the brace-expansion overrides for major versions 1, 2, and 5.

Changes

Dependency Overrides

Layer / File(s) Summary
Update brace-expansion overrides
pnpm-workspace.yaml
The override ranges for major versions 1, 2, and 5 change to ^1.1.21, ^2.1.7, and ^5.0.12.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to a6825

The dependency overrides align with the reported locked versions. No merge-blocking issue is identified; merge after normal dependency and audit checks pass.

Architecture Summary

Architecture risk: 🔵 Low · up to a6825

The change affects 1 system.

Changed systems: pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pnpm-workspace.yaml: Updated the brace-expansion overrides for major versions 1, 2, and 5 to ^1.1.21, ^2.1.7, and ^5.0.12, respectively, replacing ^1.1.17, ^2.1.4, and ^5.0.9.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the security fix and names the affected dependency vulnerability. It matches the dependency override changes.
Description check ✅ Passed The description directly explains the vulnerability, affected dependency, patched versions, and test method. It is related to the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@benoitf benoitf changed the title fix: resolve GHSA-qhr7-859c-m2p7 in brace-expansion fix: resolve GHSA-qhr7-859c-m2p7 in brace-expansion Sep 30, 2026
@benoitf
benoitf disabled auto-merge September 30, 2026 11:26
@benoitf
benoitf merged commit 493a885 into podman-desktop:main Sep 30, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants