Skip to content

Chore/billing membership misc - #41

Merged
mitchdowney merged 13 commits into
developfrom
chore/billing-membership-misc
Jun 22, 2026
Merged

Chore/billing membership misc#41
mitchdowney merged 13 commits into
developfrom
chore/billing-membership-misc

Conversation

@mitchdowney

Copy link
Copy Markdown
Member

No description provided.

mitchdowney added 11 commits May 6, 2026 01:42
…ntation

- Added a new rule for naming environment variables and exported constants related to expiration, ensuring they end with `_EXPIRATION` without additional suffixes.
- Created documentation for the `env-expiration-naming` skill to guide developers on the correct naming conventions.
- Introduced a new skill for Kustomize practices in Metaboost, detailing the composition of bases and overlays without sibling references.
- Updated the skills index to include the new Kustomize skill, enhancing the overall documentation for development practices.
- Introduced a new documentation file for the `local-postgres-wait-db-env` process, detailing the alignment of `local_postgres_wait` and `local_db_init_management` with `infra/config/local/db.env`.
- Updated Makefiles to source environment variables from `db.env`, ensuring consistency in user roles and database management.
- Removed redundant Make defaults to prevent conflicts in database identity definitions.
- Enhanced the `INFRA-DOCKER-LOCAL.md` documentation to clarify the dependency on `db.env` for local infrastructure setup.
- Introduced a new `withDashboardBreadcrumb` utility to prepend a Dashboard link to breadcrumb navigation across various pages.
- Updated multiple components and pages, including Admin, Bucket, User, and Terms Version pages, to utilize the new breadcrumb structure.
- Enhanced user navigation experience by ensuring all relevant pages display a consistent breadcrumb trail leading back to the Dashboard.
- Refactored breadcrumb-related imports and components for improved maintainability and clarity.
… practices

- Added new rules and documentation for managing app-internal import aliases, ensuring TypeScript path aliases match app directory names.
- Introduced guidelines for extracting app-local UI wrappers to avoid repetition of `@metaboost/ui` configurations.
- Established architecture tier dependency rules to prevent lower tiers from depending on higher tiers in the monorepo.
- Implemented config and type safety rules, prohibiting default values in config files and allowing non-null assertions only in specific contexts.
- Created documentation for CSS custom properties, emphasizing the avoidance of fallback arguments in SCSS/CSS.
- Updated existing rules and added new ones for build order synchronization and E2E seed ID text limits.
- Enhanced the overall structure and clarity of Cursor rules and documentation to support better developer workflows.
- Enhanced the formatting of various documentation files for better readability, including consistent table structures and improved alignment.
- Updated the `AGENTS.md` file to clarify npm script descriptions and their associated services.
- Refined skill documentation across multiple files, ensuring consistent presentation and clearer instructions for developers.
- Adjusted branch protection and GitHub setup documentation to improve clarity on secret usage and workflow triggers.
- Made minor corrections in environment variable documentation to ensure accuracy and consistency.
- Introduced new CronJobs for verifying bootstrap contracts and rebootstrap roles, enhancing database management and integrity checks.
- Updated documentation to include instructions for triggering one-off jobs and verifying bootstrap contracts during deployments.
- Added scripts for local verification of bootstrap contracts and rebootstrap processes, ensuring alignment with database roles and grants.
- Enhanced Kustomization files to include new CronJob resources and updated ConfigMaps for migration runtime scripts.
- Refactored workspace paths in package.json and package-lock.json to use wildcard patterns for better organization.
- Updated several dependencies across the project, including @vitejs/plugin-react and jsdom, to their latest versions for improved functionality and security.
- Enhanced test configuration in vitest.config.ts to support jsdom environment and include test files with .tsx extension.
- Improved documentation in various files to clarify testing practices and enhance developer experience.
- Refactored bucket detail page tests to utilize a new URL structure that avoids server redirects for empty RSS networks.
- Introduced a helper function for consistent heading retrieval in bucket one tests.
- Updated navigation logic in bucket messages tests to streamline access to the bucket detail page.
- Added a new helper for stubbing web push notifications in tests to enhance notification functionality testing.
…ccessibility

- Replaced text-based selectors with role-based selectors for the heading "E2E Bucket One" in multiple E2E test files to enhance accessibility and maintainability.
- Introduced a helper function for consistent heading retrieval in bucket detail tests.
- Updated user detail tests to utilize a constant for nonexistent user IDs, improving clarity and reducing hardcoded values.
- Added new constants for nonexistent entity IDs to the seed constants file for better management of test cases.
- Changed the import of the web-push module to use default import syntax for consistency.
- Updated all instances of mocked sendNotification calls to reference the new import structure, ensuring accurate test behavior.
- Improved clarity and maintainability of notification-related tests by aligning with the updated mocking approach.
- Updated import statements in multiple E2E test files to ensure consistent usage of the Playwright test library.
- Improved code readability by formatting the assertion in the notification web push test for better clarity.
- Enhanced maintainability of test files by aligning import structures across different test cases.
@github-actions github-actions Bot added apps Changes to apps/ ci Changes to .github/ docs Changes to docs/ i18n Changes to internationalization / translation files infra Changes to infra/ llm Changes to .cursor skills, rules, or .cursorrules—non-Cursor: re-run LLM alignment on pull packages Changes to packages/ scripts Changes to scripts/ tools Changes to tools/ labels Jun 22, 2026
- Replaced inline kustomization build script in the GitHub Actions workflow with a dedicated bash script for better maintainability.
- Updated documentation to clarify the use of a publish placeholder in kustomization files and the substitution of commit SHA during builds.
- Introduced a new script to handle the rendering of alpha overlays, improving the overall workflow and ensuring accurate builds with the correct references.
@mitchdowney

Copy link
Copy Markdown
Member Author

/test

@github-actions

Copy link
Copy Markdown

❌ CI Failed

One or more checks failed. Please review and fix the issues.

Check Status
Linear migration files valid
Linear baseline 0003 (.sql.gz) verified
DB init sync valid
Bootstrap init contract verified
Runtime CREATE EXTENSION guard
Dependencies installed
Build packages ⏭️
Lint ⏭️
Build apps ⏭️
i18n validate ⏭️
Type-check ⏭️
Test ⏭️ Skipped in CI (run locally)

Legend: ✅ Passed | ❌ Failed | ⏭️ Skipped

Reminder: run make E2E_API_GATE_MODE=on e2e_test locally before merging (or make E2E_API_GATE_MODE=on e2e_test_report for reports).

View full run for details

- Removed unnecessary "peer" property from several dependencies in package-lock.json for cleaner configuration.
- Added new dependencies for @emnapi/core and @emnapi/runtime with their respective versions and licenses.
- Updated script permissions for update-lockfile-linux.sh to ensure executable access.
@mitchdowney

Copy link
Copy Markdown
Member Author

/test

@github-actions

Copy link
Copy Markdown

✅ CI Passed

All checks completed successfully.

Check Status
Linear migration files valid
Linear baseline 0003 (.sql.gz) verified
DB init sync valid
Bootstrap init contract verified
Runtime CREATE EXTENSION guard
Dependencies installed
Build packages
Lint
Build apps
i18n validate
Type-check
Test ⏭️ Skipped in CI (run locally)

Reminder: run make E2E_API_GATE_MODE=on e2e_test locally before merging (or make E2E_API_GATE_MODE=on e2e_test_report for reports).

View full run

@mitchdowney
mitchdowney merged commit c0d219d into develop Jun 22, 2026
3 checks passed
@mitchdowney
mitchdowney deleted the chore/billing-membership-misc branch June 22, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apps Changes to apps/ ci Changes to .github/ docs Changes to docs/ i18n Changes to internationalization / translation files infra Changes to infra/ llm Changes to .cursor skills, rules, or .cursorrules—non-Cursor: re-run LLM alignment on pull packages Changes to packages/ scripts Changes to scripts/ tools Changes to tools/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant