Merged
Conversation
mbrandonw
commented
Jan 26, 2026
| withIntermediateDirectories createIntermediates: Bool, | ||
| attributes: [FileAttributeKey: Any]? | ||
| ) throws | ||
| func createDirectory(at url: URL, withIntermediateDirectories createIntermediates: Bool) throws |
Member
Author
There was a problem hiding this comment.
Unrelated to this PR, and I could move this to #5 where it belongs, but I realized that I went a little overzealous with the arguments to some of the FileSystem methods. we don't need access to all of the arguments, so scaled things back.
mbrandonw
commented
Jan 26, 2026
| allowUncontainedSymlinks: Bool, | ||
| progress: Progress?, | ||
| pathEncoding: String.Encoding? | ||
| ) throws |
mbrandonw
commented
Jan 26, 2026
Comment on lines
+14
to
+15
| func moveItem(at srcURL: URL, to dstURL: URL) throws | ||
| func contentsOfDirectory(at url: URL) throws -> [URL] |
Member
Author
There was a problem hiding this comment.
New FileSystem endpoints to implement the claude fix. We need to be able to move directories and inspect directories so that we can delete previous versions.
mbrandonw
commented
Jan 26, 2026
Comment on lines
+87
to
+91
| if installPath.hasPrefix("~/") { | ||
| expandedPath = fileSystem.homeDirectoryForCurrentUser.path + "/" + installPath.dropFirst(2) | ||
| } else { | ||
| expandedPath = installPath | ||
| } |
Member
Author
There was a problem hiding this comment.
Fixed expanding tilde paths too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
pfwdoesn't work for Claude because Claude doesn't support nested skills, e.g.~/.claude/skills/the-point-free-way/skills/SQLiteData/SKILL.md. That intermediatethe-point-free-way/skillsdirectory is a problem.So we now just copy each skill directly into the skills directory, but with a "pfw-" prefix to distinguish them from other skills. We also delete all existing "pfw-…" directories when installing.